Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsed statement visitor #2396

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Add parsed statement visitor #2396

merged 1 commit into from
Nov 12, 2023

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Nov 12, 2023

Add parsed statement visitor. This infrastructure will be needed when we implement scan from pandas.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (109b826) 91.06% compared to head (24c3204) 91.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2396      +/-   ##
==========================================
- Coverage   91.06%   91.04%   -0.02%     
==========================================
  Files        1013     1015       +2     
  Lines       35928    36014      +86     
==========================================
+ Hits        32717    32790      +73     
- Misses       3211     3224      +13     
Files Coverage Δ
src/binder/bound_statement_visitor.cpp 96.66% <100.00%> (+3.11%) ⬆️
src/include/binder/bound_statement_visitor.h 90.00% <ø> (ø)
...ude/parser/visitor/statement_read_write_analyzer.h 100.00% <100.00%> (ø)
src/main/connection.cpp 90.50% <100.00%> (-0.06%) ⬇️
...c/parser/visitor/statement_read_write_analyzer.cpp 100.00% <100.00%> (ø)
src/include/parser/parsed_statement_visitor.h 0.00% <0.00%> (ø)
src/parser/parsed_statement_visitor.cpp 80.43% <80.43%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/binder/bound_statement_visitor.cpp Outdated Show resolved Hide resolved
src/parser/parsed_statement_visitor.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit d117fe8 into master Nov 12, 2023
12 checks passed
@andyfengHKU andyfengHKU deleted the parsed-statement-visitor branch November 12, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants