Rework local storage for node table and fix #2376 #2394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR also forces flattening on updates/deletions/insertions, which is to simplify the implementation of following fixes on rel updates/deletions/insertions. This can bring performance down, though it's not profiled by how much, and should be solved at once as we optimize the update performance after all fixes.
Also, there are quite few places not covered by tests, which are mostly due to that lots of tests on rel updates are disabled. I will revisit the test coverage after my fixes on rel updates.
TODOs