Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove startPosInChunk from append() and fix incorrect numValues #2387

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Nov 10, 2023

Both ColumnChunk::append interfaces take a startPosInChunk as input, which is very confusing, as append should auto add value to its end, whose position is indicated by numValues. And this interface actually hides potentially annoying bugs related to incorrect setting of numValues.
This PR removes the param startPosInChunk and fix incorrect numValues inside NullColumnChunk.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e393e33) 91.16% compared to head (f8458fe) 91.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
+ Coverage   91.16%   91.17%   +0.01%     
==========================================
  Files        1012     1012              
  Lines       35923    35933      +10     
==========================================
+ Hits        32748    32761      +13     
+ Misses       3175     3172       -3     
Files Coverage Δ
src/include/storage/store/string_column_chunk.h 100.00% <ø> (ø)
src/include/storage/store/struct_column_chunk.h 100.00% <ø> (ø)
src/include/storage/store/var_list_column_chunk.h 90.90% <100.00%> (ø)
src/storage/local_table.cpp 94.09% <100.00%> (ø)
src/storage/store/node_group.cpp 100.00% <100.00%> (ø)
src/storage/store/string_column_chunk.cpp 84.41% <100.00%> (ø)
src/storage/store/struct_column_chunk.cpp 70.73% <100.00%> (ø)
src/storage/store/var_list_column_chunk.cpp 96.62% <100.00%> (+0.03%) ⬆️
src/include/storage/store/column_chunk.h 97.61% <80.00%> (-2.39%) ⬇️
src/storage/store/column_chunk.cpp 92.64% <82.35%> (-0.27%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 24934c6 into master Nov 11, 2023
12 checks passed
@ray6080 ray6080 deleted the var-list-finalize branch November 11, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants