Allow explicit cast between varlist CAST(var, varlist type) #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AEsir777
force-pushed
the
explicit-cast-varlist
branch
from
4f27938
to
9a73d5e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2386 +/- ##
==========================================
+ Coverage 91.04% 91.24% +0.20%
==========================================
Files 1015 1022 +7
Lines 36012 36323 +311
==========================================
+ Hits 32788 33144 +356
+ Misses 3224 3179 -45 ☔ View full report in Codecov by Sentry. |
acquamarin
requested changes
Nov 10, 2023
AEsir777
force-pushed
the
explicit-cast-varlist
branch
3 times, most recently
from
c143192
to
4d493f5
Compare
AEsir777
commented
Nov 13, 2023
| resultChildVector->setNull(i, inputChildVector->isNull(i)); | ||
| if (!resultChildVector->isNull(i)) { | ||
| // cast position i in child data vector | ||
| OP_WRAPPER::template operation<OPERAND_TYPE, RESULT_TYPE, FUNC>( |
AEsir777
force-pushed
the
explicit-cast-varlist
branch
from
4d493f5
to
1b9ac93
Compare
acquamarin
approved these changes
Nov 14, 2023
AEsir777
force-pushed
the
explicit-cast-varlist
branch
5 times, most recently
from
6e8edde
to
43cee94
Compare
AEsir777
force-pushed
the
explicit-cast-varlist
branch
from
43cee94
to
2ac1809
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark: (size of list between 0 to 40, select condition size(list) > 25)
ToDo:
add more tests for list of nested typesadd cast_error cases