fix floating to int128 and negative to int128

[Ashleyhx]

fix #2334

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd388b4) 91.01% compared to head (fba4023) 91.02%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2374   +/-   ##
=======================================
  Coverage   91.01%   91.02%           
=======================================
  Files        1015     1015           
  Lines       35823    35825    +2     
=======================================
+ Hits        32606    32611    +5     
+ Misses       3217     3214    -3     

Files	Coverage Δ
src/common/types/int128_t.cpp	88.98% <100.00%> (+0.94%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AEsir777]

Return cast(-170141183460469231731687303715884105728, "int128") reports error Cast failed. 170141183460469231731687303715884105728 is not within INT128 range. while -170141183460469231731687303715884105728 should be the smallest INT128 value.

[Ashleyhx]

Return cast(-170141183460469231731687303715884105728, "int128") reports error Cast failed. 170141183460469231731687303715884105728 is not within INT128 range. while -170141183460469231731687303715884105728 should be the smallest INT128 value.

I think we only allow -170141183460469231731687303715884105727 to 170141183460469231731687303715884105727 to avoid possible overflows.

[acquamarin]

D select cast(-170141183460469231731687303715884105728 as  hugeint);
Error: Conversion Error: Type DOUBLE with value -1.7014118346046923e+38 can't be cast because the value is out of range for the destination type INT128

Looks like duckdb fails with this number. Not sure what is the limit.

[Ashleyhx]

D select cast(-170141183460469231731687303715884105728 as  hugeint);
Error: Conversion Error: Type DOUBLE with value -1.7014118346046923e+38 can't be cast because the value is out of range for the destination type INT128

Looks like duckdb fails with this number. Not sure what is the limit.

limit is -170141183460469231731687303715884105727 not -170141183460469231731687303715884105728. otherwise it will fail here for duckdb.

[AEsir777]

D select cast(-170141183460469231731687303715884105728 as  hugeint);
Error: Conversion Error: Type DOUBLE with value -1.7014118346046923e+38 can't be cast because the value is out of range for the destination type INT128

Looks like duckdb fails with this number. Not sure what is the limit.

limit is -170141183460469231731687303715884105727 not -170141183460469231731687303715884105728. otherwise it will fail here for duckdb.

Ah, okay. So maybe we need to modify the error message? 170141183460469231731687303715884105728 is not within INT128 range. or just leave it as it is.