Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm option to modify listStartChar/EndChar in csvReaderConfig #2365

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

AEsir777
Copy link
Contributor

@AEsir777 AEsir777 commented Nov 7, 2023

No description provided.

@AEsir777 AEsir777 marked this pull request as ready for review November 7, 2023 15:50
@AEsir777 AEsir777 force-pushed the csvconfig branch 2 times, most recently from d906d10 to aa820b6 Compare November 7, 2023 16:08
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0b9a11) 90.45% compared to head (93c0222) 90.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   90.45%   90.45%   -0.01%     
==========================================
  Files        1013     1013              
  Lines       33181    33173       -8     
==========================================
- Hits        30013    30005       -8     
  Misses       3168     3168              
Files Coverage Δ
src/binder/bind/bind_file_scan.cpp 98.38% <ø> (-0.13%) ⬇️
src/function/cast_string_to_functions.cpp 99.75% <100.00%> (ø)
src/include/common/copier_config/copier_config.h 100.00% <100.00%> (ø)
...function/cast/functions/cast_string_to_functions.h 100.00% <ø> (ø)
...operator/persistent/reader/csv/base_csv_reader.cpp 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AEsir777 AEsir777 merged commit b18454e into master Nov 7, 2023
12 checks passed
@AEsir777 AEsir777 deleted the csvconfig branch November 7, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants