Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NotImplementedException with KU_NOT_REACHABLE when possible #2362

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Nov 7, 2023

No description provided.

@ray6080 ray6080 marked this pull request as ready for review November 7, 2023 06:07
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e0b9a11) 90.45% compared to head (cfc1405) 90.63%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2362      +/-   ##
==========================================
+ Coverage   90.45%   90.63%   +0.18%     
==========================================
  Files        1013     1016       +3     
  Lines       33181    35776    +2595     
==========================================
+ Hits        30013    32427    +2414     
- Misses       3168     3349     +181     
Files Coverage Δ
src/binder/bind/bind_copy.cpp 98.38% <ø> (+4.50%) ⬆️
src/binder/bind/bind_ddl.cpp 100.00% <ø> (+1.73%) ⬆️
src/binder/bind/bind_updating_clause.cpp 95.41% <ø> (+1.43%) ⬆️
src/binder/binder.cpp 99.22% <ø> (+1.51%) ⬆️
src/catalog/catalog_content.cpp 96.79% <ø> (-2.28%) ⬇️
src/catalog/table_schema.cpp 98.33% <ø> (-1.67%) ⬇️
src/common/copier_config/copier_config.cpp 54.54% <ø> (ø)
src/common/expression_type.cpp 100.00% <ø> (ø)
src/common/file_utils.cpp 80.82% <ø> (-7.64%) ⬇️
src/common/types/blob.cpp 100.00% <ø> (ø)
... and 43 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 force-pushed the ku-not-reachable branch 4 times, most recently from 4087955 to 274b996 Compare November 7, 2023 17:30
@ray6080 ray6080 merged commit 62f6f41 into master Nov 7, 2023
11 of 12 checks passed
@ray6080 ray6080 deleted the ku-not-reachable branch November 7, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants