Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clangd-diagnostics: fixup #2354

Merged
merged 1 commit into from
Nov 6, 2023
Merged

clangd-diagnostics: fixup #2354

merged 1 commit into from
Nov 6, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Nov 6, 2023

Unfortunate PR merge timing caused master to fail the diagnostics check in CI.

Unfortunate PR merge timing caused master to fail the diagnostics check
in CI.
@Riolku Riolku marked this pull request as ready for review November 6, 2023 16:58
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0da2553) 90.26% compared to head (a0123c0) 90.26%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2354   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files        1011     1011           
  Lines       32344    32344           
=======================================
+ Hits        29195    29196    +1     
+ Misses       3149     3148    -1     
Files Coverage Δ
src/binder/bind/ddl/bind_create_rdf_graph.cpp 100.00% <ø> (ø)
src/function/vector_blob_functions.cpp 85.71% <ø> (ø)
src/include/common/null_mask.h 100.00% <ø> (ø)
src/include/function/unary_function_executor.h 87.80% <ø> (ø)
src/include/storage/storage_info.h 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku merged commit f6fa4af into master Nov 6, 2023
12 checks passed
@Riolku Riolku deleted the fixup-clangd-diagnostics branch November 6, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants