Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor LogicalTypeUtils::dataTypeToString #2350

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (62f6f41) 90.63% compared to head (cd6b8e9) 90.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2350      +/-   ##
==========================================
+ Coverage   90.63%   90.77%   +0.13%     
==========================================
  Files        1016     1016              
  Lines       35776    35710      -66     
==========================================
- Hits        32427    32416      -11     
+ Misses       3349     3294      -55     
Files Coverage Δ
src/binder/bind/bind_ddl.cpp 100.00% <100.00%> (ø)
src/binder/bind/bind_graph_pattern.cpp 93.31% <100.00%> (-0.03%) ⬇️
src/binder/bind/bind_reading_clause.cpp 97.31% <100.00%> (ø)
src/binder/binder.cpp 99.22% <100.00%> (ø)
src/binder/expression/function_expression.cpp 100.00% <100.00%> (ø)
src/binder/expression_binder.cpp 95.23% <100.00%> (-0.06%) ⬇️
src/binder/query/query_graph_label_analyzer.cpp 100.00% <ø> (+3.33%) ⬆️
src/common/arrow/arrow_converter.cpp 98.11% <ø> (+2.70%) ⬆️
src/common/arrow/arrow_row_batch.cpp 56.55% <ø> (+2.95%) ⬆️
src/common/type_utils.cpp 96.59% <ø> (+3.18%) ⬆️
... and 30 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU force-pushed the types-to-string-rework branch 2 times, most recently from b604b8b to 8e5264e Compare November 7, 2023 16:33
@andyfengHKU andyfengHKU merged commit 3f7fb1b into master Nov 8, 2023
12 checks passed
@andyfengHKU andyfengHKU deleted the types-to-string-rework branch November 8, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants