Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bounds of data read in VarList updates #2346

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

benjaminwinger
Copy link
Collaborator

@benjaminwinger benjaminwinger commented Nov 3, 2023

When updating we are reading the size of the var list data column using the offset column's metadata.

Also check page bounds of reads/writes to make sure they are within the bounds set by the metadata
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84f145c) 89.23% compared to head (beba021) 90.27%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2346      +/-   ##
==========================================
+ Coverage   89.23%   90.27%   +1.04%     
==========================================
  Files        1007     1011       +4     
  Lines       32224    32312      +88     
==========================================
+ Hits        28755    29170     +415     
+ Misses       3469     3142     -327     
Files Coverage Δ
src/include/storage/store/column.h 84.21% <ø> (ø)
src/storage/store/column.cpp 87.77% <100.00%> (+0.23%) ⬆️
src/storage/store/var_list_column.cpp 99.02% <100.00%> (-0.02%) ⬇️

... and 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger changed the title Check page bounds of reads/writes Fix bounds of data read in VarList updates Nov 6, 2023
@benjaminwinger benjaminwinger merged commit b698dca into master Nov 9, 2023
12 checks passed
@benjaminwinger benjaminwinger deleted the check_chunk_bounds branch November 9, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants