ci: check for clangd diagnostics #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
no-clangd-diagnostics
branch
from
cd862e9
to
5bed230
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2344 +/- ##
==========================================
+ Coverage 90.24% 90.25% +0.01%
==========================================
Files 1011 1011
Lines 32308 32308
==========================================
+ Hits 29156 29160 +4
+ Misses 3152 3148 -4
☔ View full report in Codecov by Sentry. |
Riolku
force-pushed
the
no-clangd-diagnostics
branch
5 times, most recently
from
884245f
to
f28b88d
Compare
Riolku
force-pushed
the
no-clangd-diagnostics
branch
2 times, most recently
from
00bad2c
to
fd86404
Compare
mewim
reviewed
Nov 6, 2023
mewim
approved these changes
Nov 6, 2023
Riolku
force-pushed
the
no-clangd-diagnostics
branch
2 times, most recently
from
8253466
to
960fb89
Compare
This is a followup from #2340, which adds a check to CI for clangd diagnostics. It is added to GCC because clang is the slower of the two linux runners right now. The script itself spawns clangd and speaks Language Server Protocol to it. We open files, and clangd returns diagnostics (if any). This enables a fairly straightforward way of checking an arbitrary number of source files for warnings/errors. Simply use `make clangd-diagnostics` to run the tool. The variables `CLANGD_DIAGNOSTIC_INSTANCES` and `CLANGD_DIAGNOSTIC_JOBS` control the parallelism.
Riolku
force-pushed
the
no-clangd-diagnostics
branch
from
960fb89
to
b1efab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup from #2340, which adds a check to CI for clangd diagnostics. It is added to GCC because clang is the slower of the two linux runners right now.
The script itself spawns clangd and speaks Language Server Protocol to it. We open files, and clangd returns diagnostics (if any). This enables a fairly straightforward way of checking an arbitrary number of source files for warnings/errors.
Simply use
make clangd-diagnosticsto run the tool. The variablesCLANGD_DIAGNOSTIC_INSTANCESandNUM_THREADScontrol the parallelism.