Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed-literal storage #2341

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Add typed-literal storage #2341

merged 1 commit into from
Nov 5, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR change RDF literal type from STRING to RDF_VARIANT.

An RDF_VARIANT is a physical STRUCT{UINT8, BLOB} where UINT8 stores the type and BLOB stores the actual value. This should be a more performant storage design than STRING.

In this PR we start supporting XSD integer, double, decimal, bool and date.

src/binder/bind/bind_copy.cpp Outdated Show resolved Hide resolved
src/binder/bind/bind_ddl.cpp Outdated Show resolved Hide resolved
src/include/common/keyword/rdf_keyword.h Show resolved Hide resolved
src/include/common/keyword/rdf_keyword.h Outdated Show resolved Hide resolved
src/include/common/keyword/rdf_keyword.h Outdated Show resolved Hide resolved
src/include/function/cast/functions/cast_rdf_variant.h Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d34cefc) 89.17% compared to head (2f4dfaa) 90.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2341      +/-   ##
==========================================
+ Coverage   89.17%   90.26%   +1.08%     
==========================================
  Files        1007     1011       +4     
  Lines       32229    32308      +79     
==========================================
+ Hits        28741    29163     +422     
+ Misses       3488     3145     -343     
Files Coverage Δ
src/binder/bind/bind_copy.cpp 93.75% <ø> (+4.16%) ⬆️
src/binder/bind/bind_ddl.cpp 98.26% <ø> (+24.26%) ⬆️
src/binder/bind/copy/bind_copy_rdf_graph.cpp 100.00% <100.00%> (ø)
src/binder/bind/ddl/bind_create_rdf_graph.cpp 100.00% <100.00%> (ø)
src/common/types/rdf_variant_type.cpp 100.00% <100.00%> (ø)
src/common/types/types.cpp 0.00% <ø> (ø)
src/common/types/value/value.cpp 94.92% <ø> (ø)
src/function/cast_string_to_functions.cpp 99.72% <100.00%> (ø)
src/function/vector_cast_functions.cpp 75.00% <ø> (ø)
...rc/include/binder/expression/property_expression.h 100.00% <100.00%> (ø)
... and 7 more

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 4194475 into master Nov 5, 2023
12 checks passed
@andyfengHKU andyfengHKU deleted the typed-literal branch November 5, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants