Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move together int128 headers and fix neg int128 cast to floating numbers #2316

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

Ashleyhx
Copy link
Contributor

No description provided.

@Ashleyhx Ashleyhx changed the title move together int128 headers move together int128 headers and fix neg int128 cast to floating numbers Nov 1, 2023
src/include/common/types/int128_t.h Outdated Show resolved Hide resolved
src/include/common/types/int128_t.h Outdated Show resolved Hide resolved
src/common/types/int128_t.cpp Outdated Show resolved Hide resolved
src/common/types/int128_t.cpp Outdated Show resolved Hide resolved
src/common/types/int128_t.cpp Show resolved Hide resolved
test/test_files/tinysnb/function/cast.test Show resolved Hide resolved
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (94a611c) 89.82% compared to head (0d844e1) 89.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2316      +/-   ##
==========================================
+ Coverage   89.82%   89.83%   +0.01%     
==========================================
  Files        1022     1022              
  Lines       35452    35453       +1     
==========================================
+ Hits        31845    31850       +5     
+ Misses       3607     3603       -4     
Files Coverage Δ
src/include/common/types/int128_t.h 68.75% <ø> (ø)
src/include/common/types/value/value.h 83.87% <ø> (ø)
src/common/types/int128_t.cpp 88.03% <85.71%> (+2.19%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ashleyhx Ashleyhx marked this pull request as ready for review November 1, 2023 20:09
@Ashleyhx Ashleyhx merged commit 7b408f1 into master Nov 1, 2023
12 checks passed
@Ashleyhx Ashleyhx deleted the refactor-int128-header branch November 1, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants