Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix int128 cast to unsigned #2314

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix int128 cast to unsigned #2314

merged 2 commits into from
Oct 31, 2023

Conversation

Ashleyhx
Copy link
Contributor

fix #2270

@Ashleyhx Ashleyhx marked this pull request as ready for review October 31, 2023 18:21
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7b0c2f) 89.81% compared to head (5fae7eb) 89.82%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2314   +/-   ##
=======================================
  Coverage   89.81%   89.82%           
=======================================
  Files        1022     1022           
  Lines       35441    35443    +2     
=======================================
+ Hits        31831    31835    +4     
+ Misses       3610     3608    -2
Files Coverage Δ
src/common/types/int128_t.cpp 85.83% <100.00%> (+0.98%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ashleyhx Ashleyhx merged commit 4a9fe94 into master Oct 31, 2023
12 checks passed
@Ashleyhx Ashleyhx deleted the fix-int128-cast-unsigned branch October 31, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acquamarin acquamarin acquamarin approved these changes

@AEsir777 AEsir777 Awaiting requested review from AEsir777

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INT128 cast to unsigned int gives wrong value
2 participants
@Ashleyhx @acquamarin