Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table-function parameter match #2309

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix table-function parameter match #2309

merged 1 commit into from
Oct 31, 2023

Conversation

acquamarin
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43128fc) 89.79% compared to head (6e33ca6) 89.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2309      +/-   ##
==========================================
+ Coverage   89.79%   89.82%   +0.03%     
==========================================
  Files        1023     1022       -1     
  Lines       35447    35441       -6     
==========================================
+ Hits        31830    31836       +6     
+ Misses       3617     3605      -12     
Files Coverage Δ
src/binder/bind/bind_reading_clause.cpp 95.76% <100.00%> (+0.11%) ⬆️
...der/bind_expression/bind_comparison_expression.cpp 100.00% <100.00%> (ø)
...inder/bind_expression/bind_function_expression.cpp 96.77% <100.00%> (ø)
src/common/types/types.cpp 0.00% <ø> (ø)
src/function/built_in_functions.cpp 100.00% <100.00%> (ø)
src/function/table_functions/call_functions.cpp 96.36% <100.00%> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/function/built_in_function.h 100.00% <ø> (ø)
src/include/function/function.h 100.00% <100.00%> (ø)
src/include/function/table_functions.h 90.00% <100.00%> (+1.11%) ⬆️
... and 3 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/binder/bind/bind_reading_clause.cpp Show resolved Hide resolved
test/runner/e2e_ddl_test.cpp Outdated Show resolved Hide resolved
src/include/function/table_functions.h Outdated Show resolved Hide resolved
src/function/built_in_functions.cpp Show resolved Hide resolved
src/include/function/table_functions/bind_input.h Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit e7b0c2f into master Oct 31, 2023
12 checks passed
@acquamarin acquamarin deleted the table-function branch October 31, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants