Fix stdint includes #2305
Merged
Fix stdint includes #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string sometimes does not include cstdint and the HAVE_STDINT_H definition needs to be propagated to everything that includes miniparquet
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2305 +/- ##
==========================================
+ Coverage 89.71% 89.75% +0.03%
==========================================
Files 1023 1023
Lines 35435 35435
==========================================
+ Hits 31791 31803 +12
+ Misses 3644 3632 -12
☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<string>sometimes does not include<cstdint>and theHAVE_STDINT_Hdefinition needs to be propagated to everything that includes miniparquet (which I think was also being obscured by things including<string>).