Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue-2294 #2299

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Fix issue-2294 #2299

merged 5 commits into from
Nov 16, 2023

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Oct 30, 2023

This PR fixes issue #2294.

TODO

  • @mewim should remove marked API from C, Python, Node.js, and Java bindings.
  • @benjaminwinger should remove marked API from Rust binding.

@mewim
Copy link
Member

mewim commented Nov 10, 2023

I have removed the deprecated functions from C, Java, Node.js, and Python bindings. I do not know Rust, so @benjaminwinger should take over and remove the APIs from Rust as well.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c3b8b6) 90.49% compared to head (ebbab10) 90.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2299      +/-   ##
==========================================
+ Coverage   90.49%   90.57%   +0.07%     
==========================================
  Files        1020     1020              
  Lines       36492    36482      -10     
==========================================
+ Hits        33025    33042      +17     
+ Misses       3467     3440      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim merged commit 6f2cbcc into master Nov 16, 2023
12 checks passed
@mewim mewim deleted the issue-2294 branch November 16, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants