Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue-2293 #2298

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix issue-2293 #2298

merged 1 commit into from
Oct 30, 2023

Conversation

andyfengHKU
Copy link
Contributor

Fix issue #2293. The problem is that we always assume internal ID to be non-NULL during update which is not true in case of OPTIONAL MATCH.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9b569a4) 89.69% compared to head (89816a3) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2298   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files        1023     1023           
  Lines       35456    35474   +18     
=======================================
+ Hits        31801    31818   +17     
- Misses       3655     3656    +1     
Files Coverage Δ
.../processor/operator/persistent/insert_executor.cpp 97.89% <100.00%> (+0.14%) ⬆️
src/processor/operator/persistent/set_executor.cpp 97.84% <100.00%> (+0.02%) ⬆️
src/storage/local_table.cpp 94.19% <100.00%> (+0.02%) ⬆️
src/storage/store/node_table.cpp 100.00% <100.00%> (ø)
src/storage/store/rel_table.cpp 95.84% <100.00%> (+0.05%) ⬆️
src/storage/index/hash_index.cpp 96.32% <50.00%> (-0.77%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit abc1cae into master Oct 30, 2023
12 checks passed
@ray6080 ray6080 deleted the issue-2293 branch October 30, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants