Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2276 #2296

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix 2276 #2296

merged 1 commit into from
Oct 30, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Oct 29, 2023

This PR makes two changes:

  • Move enum classes in common to common/enums.
  • Fix 2276 by passing in AccessMode to storage data structures that need to open files. When the access mode is READ_ONLY, we should open the file in a read only mode.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (627b5f5) 89.67% compared to head (dc598e9) 89.79%.
Report is 6 commits behind head on master.

❗ Current head dc598e9 differs from pull request most recent head 04f08ba. Consider uploading reports for the commit 04f08ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
+ Coverage   89.67%   89.79%   +0.12%     
==========================================
  Files        1023     1023              
  Lines       35449    35412      -37     
==========================================
+ Hits        31788    31798      +10     
+ Misses       3661     3614      -47     
Files Coverage Δ
src/binder/bind/bind_copy.cpp 94.73% <ø> (ø)
src/common/expression_type.cpp 87.50% <ø> (ø)
src/common/rel_direction.cpp 66.66% <ø> (ø)
src/common/table_type.cpp 75.00% <ø> (ø)
src/include/binder/bound_comment_on.h 100.00% <ø> (ø)
src/include/binder/bound_explain.h 100.00% <ø> (ø)
src/include/binder/bound_statement.h 100.00% <ø> (ø)
src/include/binder/ddl/bound_alter_info.h 100.00% <ø> (ø)
src/include/binder/expression/expression.h 91.30% <ø> (ø)
src/include/binder/expression/rel_expression.h 100.00% <ø> (ø)
... and 62 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 6dda3e4 into master Oct 30, 2023
10 checks passed
@ray6080 ray6080 deleted the fix-2276 branch October 30, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot open database files even in read-only mode if the file system is read-only
2 participants