Update LLVM toolchain to version 17 on hosted-runners #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2280 +/- ##
==========================================
- Coverage 89.74% 89.73% -0.02%
==========================================
Files 1027 1027
Lines 36151 36151
==========================================
- Hits 32443 32439 -4
- Misses 3708 3712 +4 ☔ View full report in Codecov by Sentry. |
mewim
changed the title
Riolku
approved these changes
Oct 27, 2023
| - name: Install clang-format | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y clang-format-11 |
There was a problem hiding this comment.
Are we delaying clang format 17 upgrade?
There was a problem hiding this comment.
clang-format is not backward compatible. If we use clang-format-17 we need to also edit .clang-format to achieve the same format. Since I am not familiar with clang-format, I did not handle it in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also move small jobs to GitHub-hosted runners