Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixed-list,union,map functions #2278

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Add fixed-list,union,map functions #2278

merged 1 commit into from
Oct 27, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Oct 26, 2023

Closes #2236

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40a4a16) 89.61% compared to head (5a7f1ea) 89.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2278      +/-   ##
==========================================
+ Coverage   89.61%   89.63%   +0.01%     
==========================================
  Files        1024     1024              
  Lines       36031    36079      +48     
==========================================
+ Hits        32290    32340      +50     
+ Misses       3741     3739       -2     
Files Coverage Δ
src/common/type_utils.cpp 93.25% <100.00%> (+7.00%) ⬆️
src/common/types/types.cpp 0.00% <ø> (ø)
src/function/vector_cast_functions.cpp 86.22% <100.00%> (+3.26%) ⬆️
src/include/common/type_utils.h 100.00% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/common/vector/value_vector.h 100.00% <100.00%> (ø)
...c/include/function/cast/functions/cast_functions.h 97.91% <100.00%> (ø)
src/include/function/union/functions/union_tag.h 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit fe021e9 into master Oct 27, 2023
12 checks passed
@acquamarin acquamarin deleted the fixed-list-function branch October 27, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FixedList to string casting
2 participants