Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

third_party/re2: fix is_pod deprecation warning #2262

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Riolku
Copy link
Collaborator

@Riolku Riolku commented Oct 25, 2023

std::is_pod is deprecated in C++20. This was the noisiest of the warnings in our codebase.

std::is_pod is deprecated in C++20. This was the noisiest of the
warnings in our codebase.
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb5c8bd) 89.59% compared to head (55400a1) 89.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2262      +/-   ##
==========================================
+ Coverage   89.59%   89.61%   +0.01%     
==========================================
  Files        1016     1016              
  Lines       35806    35806              
==========================================
+ Hits        32081    32086       +5     
+ Misses       3725     3720       -5     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku merged commit 314781c into master Oct 25, 2023
12 checks passed
@Riolku Riolku deleted the regex-deprecation-warnings branch October 25, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants