Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to use wrapper function to wrap all the codes in cast_string_to_function.h #2261

Merged
merged 1 commit into from
Oct 26, 2023

refactor to use wrapper function to wrap all the codes in

22c50a2
Select commit
Loading
Failed to load commit list.
Merged

refactor to use wrapper function to wrap all the codes in cast_string_to_function.h #2261

refactor to use wrapper function to wrap all the codes in
22c50a2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 26, 2023 in 0s

89.61% (target 80.00%)

View this Pull Request on Codecov

89.61% (target 80.00%)

Details

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ecf1dd2) 89.60% compared to head (22c50a2) 89.61%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2261    +/-   ##
========================================
  Coverage   89.60%   89.61%            
========================================
  Files        1016     1024     +8     
  Lines       35808    36031   +223     
========================================
+ Hits        32085    32288   +203     
- Misses       3723     3743    +20     
Files Coverage Δ
src/binder/bind/bind_graph_pattern.cpp 96.22% <100.00%> (+0.02%) ⬆️
src/function/cast_string_non_nested_functions.cpp 100.00% <100.00%> (ø)
src/function/vector_cast_functions.cpp 82.96% <100.00%> (+1.80%) ⬆️
src/function/vector_union_functions.cpp 91.66% <100.00%> (ø)
src/include/common/type_utils.h 100.00% <100.00%> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
.../cast/functions/cast_string_non_nested_functions.h 97.33% <100.00%> (ø)
src/include/function/cast/functions/numeric_cast.h 100.00% <100.00%> (ø)
src/include/function/cast/vector_cast_functions.h 95.34% <100.00%> (-0.57%) ⬇️
.../include/function/string/vector_string_functions.h 96.00% <100.00%> (ø)
... and 17 more

... and 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.