reader/csv: use exception-safe locks #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2258 +/- ##
==========================================
+ Coverage 89.61% 89.62% +0.01%
==========================================
Files 1016 1016
Lines 35808 35806 -2
==========================================
+ Hits 32088 32091 +3
+ Misses 3720 3715 -5
☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Oct 24, 2023
Riolku
force-pushed
the
reader-exception-safe-locks
branch
from
4670f71
to
77a3194
Compare
Closes #2253. Exceptions in the CSV parsing could cause a task to never wake up from sleeping on a lock.
Riolku
force-pushed
the
reader-exception-safe-locks
branch
from
77a3194
to
6dcb420
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2253. Exceptions in the CSV parsing could cause a task to never wake up from sleeping on a lock.