Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy bug #2243

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Fix copy bug #2243

merged 1 commit into from
Oct 22, 2023

Conversation

acquamarin
Copy link
Collaborator

Closes #2232

@Riolku
Copy link
Contributor

Riolku commented Oct 20, 2023

Rerunning gcc build because coverage uploading failed.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cf28bdd) 89.71% compared to head (e8c8551) 89.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2243      +/-   ##
==========================================
+ Coverage   89.71%   89.73%   +0.01%     
==========================================
  Files        1013     1013              
  Lines       35846    35845       -1     
==========================================
+ Hits        32161    32167       +6     
+ Misses       3685     3678       -7     
Files Coverage Δ
src/common/exception/message.cpp 83.33% <100.00%> (ø)
src/include/common/exception/message.h 60.00% <ø> (ø)
src/include/storage/store/table_copy_utils.h 0.00% <ø> (ø)
src/include/storage/store/var_list_column_chunk.h 85.71% <ø> (-1.79%) ⬇️
...rocessor/operator/persistent/reader/csv/driver.cpp 98.76% <100.00%> (+0.49%) ⬆️
...e/in_mem_storage_structure/in_mem_column_chunk.cpp 54.54% <100.00%> (+0.42%) ⬆️
.../storage/in_mem_storage_structure/in_mem_lists.cpp 63.49% <100.00%> (+0.49%) ⬆️
src/storage/local_table.cpp 94.17% <100.00%> (-0.03%) ⬇️
src/storage/store/table_copy_utils.cpp 83.07% <ø> (ø)
src/storage/store/var_list_column_chunk.cpp 83.92% <100.00%> (+2.67%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/processor/operator/persistent/reader/csv/driver.cpp Outdated Show resolved Hide resolved
src/storage/store/var_list_column_chunk.cpp Show resolved Hide resolved
test/test_files/copy/copy_edge_case.test Outdated Show resolved Hide resolved
test/test_files/copy/copy_edge_case.test Show resolved Hide resolved
test/test_files/copy/copy_edge_case.test Outdated Show resolved Hide resolved
test/test_files/copy/copy_long_string.test Show resolved Hide resolved
test/test_files/copy/copy_edge_case.test Outdated Show resolved Hide resolved
test/test_files/copy/copy_edge_case.test Outdated Show resolved Hide resolved
@Riolku
Copy link
Contributor

Riolku commented Oct 20, 2023

General comment, we should cancel CI runs that are redundant. I cancelled run #6875 for you.

src/storage/store/table_copy_utils.cpp Outdated Show resolved Hide resolved
src/storage/store/table_copy_utils.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 2e4fde9 into master Oct 22, 2023
12 checks passed
@acquamarin acquamarin deleted the column-chunk-fix branch October 22, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long string & lists cause SIGSEGV Heap Buffer Overflow
2 participants