-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy to csv rework #2242
Copy to csv rework #2242
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2242 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 1012 1013 +1
Lines 35862 35846 -16
=======================================
- Hits 32167 32153 -14
+ Misses 3695 3693 -2
☔ View full report in Codecov by Sentry. |
7209034
to
39a4286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at coverage. I feel it should be covered but the report says no.
39a4286
to
4bed782
Compare
This PR improves the existing copy-to-csv:
E2E performance on copy ldbc-100 to csv file:
60452.38ms (M1 Max, 32GB RAM)