Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use env vars for parallelism #2241

Merged
merged 1 commit into from
Oct 23, 2023
Merged

ci: use env vars for parallelism #2241

merged 1 commit into from
Oct 23, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Oct 19, 2023

This commit also configures TEST_JOBS to be half of NUM_THREADS, since our tests use 2 threads right now.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ebc7f1) 89.73% compared to head (a2885aa) 89.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2241      +/-   ##
==========================================
+ Coverage   89.73%   89.75%   +0.01%     
==========================================
  Files        1014     1014              
  Lines       35859    35859              
==========================================
+ Hits        32178    32185       +7     
+ Misses       3681     3674       -7     
Files Coverage Δ
src/include/storage/index/hash_index_builder.h 79.06% <ø> (ø)
src/storage/index/hash_index_builder.cpp 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku force-pushed the ci-env-vars branch 2 times, most recently from 449a284 to 8eb23fd Compare October 19, 2023 20:58
This commit also configures TEST_JOBS to be half of NUM_THREADS, since
our tests use 2 threads right now.
@Riolku Riolku marked this pull request as ready for review October 23, 2023 15:04
@Riolku Riolku requested a review from mewim October 23, 2023 15:05
@Riolku
Copy link
Contributor Author

Riolku commented Oct 23, 2023

Further considerations: should we overcommit TEST_JOBS ?

@Riolku Riolku merged commit de9dd77 into master Oct 23, 2023
12 checks passed
@Riolku Riolku deleted the ci-env-vars branch October 23, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants