Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use full ASAN #2231

Merged
merged 2 commits into from
Oct 23, 2023
Merged

ci: use full ASAN #2231

merged 2 commits into from
Oct 23, 2023

Commits on Oct 19, 2023

  1. storage/buffer_manager: use locking queue 

    The lock-free queue is the source of an ASAN failure. Specifically, the
queue does not guarantee strict FIFO circumstances in the name of speed.
This means that our code that loops through the queue is incorrect.

The goal is to replace this queue-based design soon regardless, and
hence we don't want to spend more time on this.

Also, this commit removes a useless logger in the buffer manager.
    @Riolku
    Riolku committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b70c101 View commit details
    Browse the repository at this point in the history

  2. ci: use full ASAN 

    Previously we used LD_PRELOAD to add ASAN to our build. This is at best
imperfect, since the full benefits of ASAN can only be realized by
adding compiler instrumentation.

This does not run the python, nodejs, or java tests with ASAN. Though
Python can be run with ASAN using LD_PRELOAD, it is super slow, and
would need parallelized testing to be viable (which is not worth it
IMO).

Nodejs and Java just die spectacularly. Overall I think the APIs need
ASAN much less.
    @Riolku
    Riolku committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    34671ef View commit details
    Browse the repository at this point in the history