Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of test query threads #2228

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Reduce number of test query threads #2228

merged 1 commit into from
Oct 17, 2023

Conversation

benjaminwinger
Copy link
Collaborator

@benjaminwinger benjaminwinger commented Oct 17, 2023

Seems to significantly slow down our tests as they work with many small operations on systems with many processors. Particularly when running many tests in parallel, it seems unnecessary to use the default number of threads.

Testing to see what the speedup is for CI Seems like an improvement compared to the last time CI was this quiet; oddly windows doesn't seem any different from the previous run, but that machine doesn't have as many threads, and is running much faster since I stopped the antivirus from scanning the test database files anyway.

Seems to significantly slow down our tests as they work with many small operations on systems with many processors
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (fc71a74) 89.58% compared to head (9af0a2f) 89.69%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
+ Coverage   89.58%   89.69%   +0.11%     
==========================================
  Files        1006     1008       +2     
  Lines       36313    35830     -483     
==========================================
- Hits        32530    32139     -391     
+ Misses       3783     3691      -92     
Files Coverage Δ
src/binder/bind/bind_copy.cpp 94.83% <100.00%> (ø)
src/binder/bind/bind_create_macro.cpp 100.00% <100.00%> (+10.00%) ⬆️
src/binder/bind/bind_ddl.cpp 98.48% <100.00%> (+1.03%) ⬆️
src/binder/bind/bind_file_scan.cpp 98.46% <100.00%> (+1.44%) ⬆️
src/binder/bind/bind_graph_pattern.cpp 96.19% <100.00%> (+1.47%) ⬆️
src/binder/bind/bind_reading_clause.cpp 95.61% <100.00%> (-0.04%) ⬇️
src/binder/bind/bind_updating_clause.cpp 95.48% <100.00%> (ø)
...inder/bind_expression/bind_property_expression.cpp 93.33% <100.00%> (ø)
src/binder/binder.cpp 97.70% <100.00%> (-0.04%) ⬇️
src/binder/expression_binder.cpp 97.50% <100.00%> (-0.07%) ⬇️
... and 62 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger marked this pull request as ready for review October 17, 2023 22:31
@mewim
Copy link
Collaborator

mewim commented Oct 17, 2023

is running much faster since I stopped the antivirus from scanning the test database files anyway

LOL. I did not expect this to be the root cause of the slowdown.

@mewim mewim merged commit b79718b into master Oct 17, 2023
11 of 12 checks passed
@mewim mewim deleted the test-threads branch October 17, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants