Buffered serialization #2225
Merged
Buffered serialization #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquamarin
approved these changes
Oct 17, 2023
acquamarin
reviewed
Oct 17, 2023
benjaminwinger
force-pushed
the
buffered-serialization
branch
from
18cd20c
to
f2d05f4
Compare
Can that be left to a later PR, or do you want it included in this one? |
benjaminwinger
force-pushed
the
buffered-serialization
branch
from
f2d05f4
to
e73855d
Compare
I think i can do it in later PRs. |
benjaminwinger
force-pushed
the
buffered-serialization
branch
from
e73855d
to
ab45436
Compare
benjaminwinger
force-pushed
the
buffered-serialization
branch
from
ab45436
to
32829cb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
==========================================
+ Coverage 89.67% 89.69% +0.01%
==========================================
Files 1008 1012 +4
Lines 35830 35862 +32
==========================================
+ Hits 32131 32166 +35
+ Misses 3699 3696 -3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the SerDeser class into a Serializer and Deserializer, and a BufferedFileWriter (for serializing to disk), and BufferedSerializer (for serializing to an in-memory buffer).