Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size() alias #2220

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add size() alias #2220

merged 1 commit into from
Oct 16, 2023

Conversation

acquamarin
Copy link
Collaborator

Closes #2218

test/test_files/tinysnb/function/list.test Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c604332) 89.58% compared to head (d52b57a) 89.55%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2220      +/-   ##
==========================================
- Coverage   89.58%   89.55%   -0.04%     
==========================================
  Files        1007     1006       -1     
  Lines       36249    36245       -4     
==========================================
- Hits        32475    32459      -16     
- Misses       3774     3786      +12     
Files Coverage Δ
src/function/built_in_vector_functions.cpp 96.31% <100.00%> (-0.02%) ⬇️
src/function/vector_list_functions.cpp 93.35% <100.00%> (+0.02%) ⬆️
src/function/vector_string_functions.cpp 87.56% <ø> (+0.13%) ⬆️
...nclude/function/list/functions/list_len_function.h 100.00% <100.00%> (ø)
src/include/function/list/vector_list_functions.h 95.08% <ø> (ø)
...function/string/functions/array_extract_function.h 90.32% <100.00%> (ø)
...include/function/string/functions/left_operation.h 100.00% <100.00%> (ø)
...include/function/string/functions/right_function.h 100.00% <100.00%> (ø)
.../include/function/string/vector_string_functions.h 96.00% <ø> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit 8a086ae into master Oct 16, 2023
11 checks passed
@acquamarin acquamarin deleted the size-function branch October 16, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename len() to size() for compatibility with openCypher
2 participants