Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change offset vector from int64 to internal_id when reading from files #2219

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Oct 16, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c604332) 89.58% compared to head (b07286b) 89.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2219      +/-   ##
==========================================
- Coverage   89.58%   89.56%   -0.03%     
==========================================
  Files        1007     1007              
  Lines       36249    36250       +1     
==========================================
- Hits        32475    32468       -7     
- Misses       3774     3782       +8     
Files Coverage Δ
src/binder/bind/bind_copy.cpp 94.83% <100.00%> (ø)
src/include/binder/copy/bound_file_scan_info.h 100.00% <100.00%> (ø)
src/include/catalog/property.h 100.00% <ø> (ø)
...c/include/processor/operator/persistent/copy_rel.h 100.00% <100.00%> (ø)
src/include/processor/operator/persistent/reader.h 100.00% <100.00%> (ø)
src/planner/operator/scan/logical_scan_file.cpp 100.00% <100.00%> (ø)
src/processor/map/map_copy_from.cpp 100.00% <100.00%> (ø)
src/processor/map/map_scan_file.cpp 100.00% <100.00%> (ø)
...processor/operator/persistent/copy_rel_columns.cpp 100.00% <100.00%> (ø)
...c/processor/operator/persistent/copy_rel_lists.cpp 100.00% <100.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 1a3b814 into master Oct 16, 2023
11 checks passed
@ray6080 ray6080 deleted the offset branch October 16, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants