Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate table metadata printing functions #2207

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

mewim
Copy link
Collaborator

@mewim mewim commented Oct 13, 2023

As discussed, we deprecate all functions for getting the table names and properties from the client APIs and the CLI as the feature is now covered by database calls.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (72dcb79) 89.45% compared to head (ee8f1b1) 89.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2207      +/-   ##
==========================================
+ Coverage   89.45%   89.46%   +0.01%     
==========================================
  Files        1007     1007              
  Lines       36314    36168     -146     
==========================================
- Hits        32485    32359     -126     
+ Misses       3829     3809      -20     
Files Coverage Δ
src/c_api/connection.cpp 93.87% <ø> (-1.51%) ⬇️
src/include/main/connection.h 100.00% <ø> (ø)
src/main/connection.cpp 90.13% <ø> (-2.41%) ⬇️
tools/java_api/src/jni/kuzu_java.cpp 83.00% <ø> (+2.83%) ⬆️
tools/nodejs_api/src_cpp/include/node_connection.h 76.19% <ø> (-12.70%) ⬇️
tools/nodejs_api/src_cpp/node_connection.cpp 93.02% <ø> (-2.87%) ⬇️
tools/python_api/src_cpp/include/py_connection.h 100.00% <ø> (ø)
tools/python_api/src_cpp/py_connection.cpp 90.15% <ø> (+0.64%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim merged commit 239317d into master Oct 13, 2023
11 checks passed
@mewim mewim deleted the api-metadata-function-fix branch October 13, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js and Python APIs output wrong property names and types when there is a space in property name
2 participants