Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac build #2204

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix mac build #2204

merged 1 commit into from
Oct 13, 2023

Conversation

acquamarin
Copy link
Collaborator

  1. Explicit export causes ValueVector::setValue not be called correctly. Disabled explicit export on mac.
  2. Fix structColumn resizing bug.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f72b71f) 89.69% compared to head (34b6f5b) 89.40%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2204      +/-   ##
==========================================
- Coverage   89.69%   89.40%   -0.30%     
==========================================
  Files         989     1007      +18     
  Lines       35429    36243     +814     
==========================================
+ Hits        31778    32402     +624     
- Misses       3651     3841     +190     
Files Coverage Δ
...rocessor/operator/persistent/reader/csv/driver.cpp 95.63% <100.00%> (-0.39%) ⬇️
src/storage/store/column_chunk.cpp 81.67% <100.00%> (-3.00%) ⬇️

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger mentioned this pull request Oct 12, 2023
6 tasks
@Riolku
Copy link
Contributor

Riolku commented Oct 13, 2023

Why does this happen, and why on mac only? Whats the proper solution, surely "disable explicit symbol exports" isnt the only solution.

@acquamarin
Copy link
Collaborator Author

Why does this happen, and why on mac only? Whats the proper solution, surely "disable explicit symbol exports" isnt the only solution.

@benjaminwinger is continuing investigating this.

@Riolku
Copy link
Contributor

Riolku commented Oct 13, 2023

Why does this happen, and why on mac only? Whats the proper solution, surely "disable explicit symbol exports" isnt the only solution.

@benjaminwinger is continuing investigating this.

Ok, let's merge this as a hotfix in the meantime.

@acquamarin acquamarin merged commit a755f57 into master Oct 13, 2023
11 checks passed
@acquamarin acquamarin deleted the fix-mac-build branch October 13, 2023 02:17
@Riolku Riolku mentioned this pull request Oct 13, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants