Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish cast string to map #2201

Merged
merged 1 commit into from
Oct 13, 2023
Merged

finish cast string to map #2201

merged 1 commit into from
Oct 13, 2023

Conversation

AEsir777
Copy link
Contributor

@AEsir777 AEsir777 commented Oct 12, 2023

  • fix nested type
  • typo in union data chunk
  • update: fix std::string_view{}
    To fix:
  • do I need to allow null for struct/map?
  • {c:1, c: 2} overwrites the original value (Acceptable)
format Old New
MAP(MAP(INT64, INT64), MAP(STRING, STRING)) x 100000 no support 1768
MAP(INT64, STRING)x 50000 4215.386 432.61

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (faa5f98) 89.43% compared to head (a51e7f8) 89.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2201      +/-   ##
==========================================
+ Coverage   89.43%   89.46%   +0.03%     
==========================================
  Files        1007     1007              
  Lines       36317    36385      +68     
==========================================
+ Hits        32479    32553      +74     
+ Misses       3838     3832       -6     
Files Coverage Δ
src/common/types/types.cpp 91.27% <100.00%> (ø)
src/include/common/string_utils.h 75.00% <ø> (ø)
...rocessor/operator/persistent/reader/csv/driver.cpp 96.41% <100.00%> (+0.78%) ⬆️
src/common/string_utils.cpp 96.36% <92.30%> (-1.26%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/common/string_utils.cpp Show resolved Hide resolved
@AEsir777 AEsir777 merged commit 964925f into master Oct 13, 2023
11 checks passed
@AEsir777 AEsir777 deleted the cast branch October 13, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants