Enable clang-analyzer #2194
Merged
Enable clang-analyzer #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
clang-tidy-analyzer
branch
7 times, most recently
from
8432501
to
ee3bc67
Compare
acquamarin
approved these changes
Oct 12, 2023
Riolku
force-pushed
the
clang-tidy-analyzer
branch
from
ee3bc67
to
0db2d9a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2194 +/- ##
==========================================
+ Coverage 89.58% 89.68% +0.10%
==========================================
Files 1006 1008 +2
Lines 36313 35830 -483
==========================================
- Hits 32530 32135 -395
+ Misses 3783 3695 -88
☔ View full report in Codecov by Sentry. |
|
The missing coverage is a good opportunity to make sure we hit all these errors. I suppose I will add tests for these tomorrow/monday. |
Riolku
force-pushed
the
clang-tidy-analyzer
branch
3 times, most recently
from
bf5e94b
to
564a9ae
Compare
Riolku
force-pushed
the
clang-tidy-analyzer
branch
6 times, most recently
from
2ec9964
to
7e43e23
Compare
Using spdlog::fmt (which is really just fmtlib) is overkill. Our
codebase only uses `{}`, and so this commit implements exactly that
(along with the ability to escape values). Experimentally this gives us
a 15% compilation speedup.
It also moves string formatting to its own file, because of how often it
is included. Finally, this change is conducive to adding clang-analyzer
to clang-tidy, as spdlog has an unitialized object warning.
This enables a myriad of complex checks.
Riolku
force-pushed
the
clang-tidy-analyzer
branch
from
7e43e23
to
3ab4c79
Compare
Add a test for every error not covered, as reported by lcov for lines changed after the stringFormat change.
Riolku
force-pushed
the
clang-tidy-analyzer
branch
from
3ab4c79
to
9a4d2a6
Compare
|
The leftover missing coverage will be handled in followup PRs. It's all non-trivial changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new handwritten
stringFormatfunction (maybe it should be calledStringFormat::fmt?)Using spdlog::fmt (which is really just fmtlib) is overkill. Our
codebase only uses
{}, and so this commit implements exactly that(along with the ability to escape values). Experimentally this gives us
a 15% compilation speedup.
It also moves string formatting to its own file, because of how often it
is included. Finally, this change is conducive to adding clang-analyzer
to clang-tidy, as spdlog has an unitialized object warning.
Finally, this PR enables clang-analyzer in clang-tidy.