Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Union support #2193

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Rust Union support #2193

merged 1 commit into from
Oct 12, 2023

Conversation

benjaminwinger
Copy link
Collaborator

I encountered a minor issue after rebasing onto the most recent commits: that the StructNodeColumn was asserting that the logical type is STRUCT, while that code is also being used for unions.

I also updated the documentation links in the rust-doc to the new locations.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (e0507dd) 89.67% compared to head (ffb7df9) 89.66%.
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
- Coverage   89.67%   89.66%   -0.01%     
==========================================
  Files         989      989              
  Lines       35389    35429      +40     
==========================================
+ Hits        31735    31769      +34     
- Misses       3654     3660       +6     
Files Coverage Δ
src/binder/bind/bind_graph_pattern.cpp 94.72% <100.00%> (ø)
...inder/bind_expression/bind_function_expression.cpp 96.77% <100.00%> (ø)
...inder/bind_expression/bind_property_expression.cpp 93.33% <100.00%> (ø)
src/binder/bound_statement_visitor.cpp 93.54% <100.00%> (ø)
src/binder/visitor/property_collector.cpp 98.41% <100.00%> (ø)
src/common/arrow/arrow_converter.cpp 95.41% <ø> (ø)
src/common/type_utils.cpp 69.81% <100.00%> (ø)
src/common/types/date_t.cpp 89.57% <ø> (ø)
src/common/types/dtime_t.cpp 74.68% <ø> (ø)
src/common/types/types.cpp 92.17% <100.00%> (+0.03%) ⬆️
... and 100 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit f72b71f into master Oct 12, 2023
11 checks passed
@benjaminwinger benjaminwinger deleted the rust-union branch October 12, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants