Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash node rel #2192

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix hash node rel #2192

merged 1 commit into from
Oct 13, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR fixes the bug when hashing NODE/REL where there is no dependent key.

We don't support hashing STRUCT, so hashing NODE/REL we always rewrite as hashing INTERNAL_ID and treat NODE/REL as dependent key i.e. payload. This rewrite fails for UNION because we don't have a way to rewrite the projection list of each subquery under UNION (technically we can but this is not the right way to approach the problem).

This PR adds hash function and compare function for NODE/REL data type.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (2d1acf4) 89.42% compared to head (959229d) 89.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2192      +/-   ##
==========================================
+ Coverage   89.42%   89.45%   +0.03%     
==========================================
  Files        1007     1007              
  Lines       36292    36314      +22     
==========================================
+ Hits        32453    32485      +32     
+ Misses       3839     3829      -10     
Files Coverage Δ
src/binder/bind/bind_projection_clause.cpp 93.33% <ø> (-0.05%) ⬇️
src/function/vector_hash_functions.cpp 90.00% <100.00%> (+3.46%) ⬆️
...rocessor/operator/aggregate/aggregate_hash_table.h 77.77% <ø> (-4.05%) ⬇️
src/optimizer/agg_key_dependency_optimizer.cpp 100.00% <100.00%> (ø)
...cessor/operator/aggregate/aggregate_hash_table.cpp 84.83% <82.22%> (+0.69%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/function/vector_hash_functions.cpp Outdated Show resolved Hide resolved
src/function/vector_hash_functions.cpp Outdated Show resolved Hide resolved
src/function/vector_hash_functions.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 72dcb79 into master Oct 13, 2023
11 checks passed
@andyfengHKU andyfengHKU deleted the fix-hash-node-rel branch October 13, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants