Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2174 for Node.js #2183

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix #2174 for Node.js #2183

merged 1 commit into from
Oct 11, 2023

Conversation

mewim
Copy link
Member

@mewim mewim commented Oct 11, 2023

@mewim mewim changed the title Fix #2147 for Node.js Fix #2174 for Node.js Oct 11, 2023
@mewim mewim requested a review from ray6080 October 11, 2023 11:44
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b5a73a8) 90.11% compared to head (4714827) 90.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2183      +/-   ##
==========================================
- Coverage   90.11%   90.08%   -0.04%     
==========================================
  Files         990      990              
  Lines       35473    35479       +6     
==========================================
- Hits        31966    31960       -6     
- Misses       3507     3519      +12     
Files Coverage Δ
tools/nodejs_api/src_cpp/node_util.cpp 94.52% <100.00%> (+0.23%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim merged commit dad1b71 into master Oct 11, 2023
11 checks passed
@mewim mewim deleted the fix-2147-node branch October 11, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants