fix q03 in benchmark #2180
Merged
fix q03 in benchmark #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we skip it instead of rewriting it with the concat function? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2180 +/- ##
==========================================
- Coverage 90.07% 89.66% -0.42%
==========================================
Files 990 989 -1
Lines 35518 35429 -89
==========================================
- Hits 31994 31767 -227
- Misses 3524 3662 +138 ☔ View full report in Codecov by Sentry. |
|
We have string concat functions: https://kuzudb.com/docusaurus/cypher/expressions/text-functions. |
added 2 commits
October 12, 2023 12:22
This reverts commit 8e0d41a.
acquamarin
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query has failed for a while in the benchmark suite. Skip this for now.
An issue is opened for this #2179.