-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parquet writer #2177
Merged
Merged
Parquet writer #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45983c9
to
00ad3ae
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2177 +/- ##
==========================================
- Coverage 89.92% 89.40% -0.52%
==========================================
Files 989 1007 +18
Lines 35637 36241 +604
==========================================
+ Hits 32048 32403 +355
- Misses 3589 3838 +249
☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In this PR, can we add some benchmark numbers on exporting to parquet file? perhaps on LDBC100 comment table.
- In following PRs, We should rewrite our testing for converting csv to parquet to use
COPY TO parquet
, which should also increase test coverage for parquet writer.
src/processor/operator/persistent/writer/parquet/parquet_writer.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/writer/parquet/column_writer.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/writer/parquet/column_writer.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/writer/parquet/column_writer.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/writer/parquet/parquet_writer.cpp
Outdated
Show resolved
Hide resolved
8b5ddbb
to
d634e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance number on ldbc100 comment: