Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Map to rust API #2176

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add support for Map to rust API #2176

merged 1 commit into from
Oct 11, 2023

Conversation

benjaminwinger
Copy link
Collaborator

For #2174

I also re-enabled some database tests which are now supported.

Passing var lists, fixed lists and maps as query parameters is producing either memory errors, or out of control memory leaks, is that expected?

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2a19754) 89.62% compared to head (5f2615b) 90.11%.
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2176      +/-   ##
==========================================
+ Coverage   89.62%   90.11%   +0.49%     
==========================================
  Files         989      990       +1     
  Lines       35740    35481     -259     
==========================================
- Hits        32031    31974      -57     
+ Misses       3709     3507     -202     
Files Coverage Δ
src/common/types/types.cpp 92.29% <100.00%> (+0.24%) ⬆️
src/include/common/types/types.h 100.00% <ø> (ø)

... and 82 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/common/types/types.cpp Outdated Show resolved Hide resolved
Also re-enabled some database tests which are now supported.
@benjaminwinger benjaminwinger merged commit a5e8e62 into master Oct 11, 2023
11 checks passed
@benjaminwinger benjaminwinger deleted the rust-map branch October 11, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants