Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move child chunks and columns to struct #2173

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Move child chunks and columns to struct #2173

merged 1 commit into from
Oct 11, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Oct 10, 2023

  • Remove CSVReaderConfig from ColumnChunk.
  • Move child chunks and columns into struct specific data structures.
  • Merge initialize and resize logic in BooleanColumnChunk into ColumnChunk.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (fe7de00) 90.07% compared to head (84568fb) 90.07%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2173      +/-   ##
==========================================
- Coverage   90.07%   90.07%   -0.01%     
==========================================
  Files         990      990              
  Lines       35518    35502      -16     
==========================================
- Hits        31994    31977      -17     
- Misses       3524     3525       +1     
Files Coverage Δ
.../include/processor/operator/persistent/copy_node.h 100.00% <100.00%> (ø)
src/include/storage/store/column_chunk.h 94.28% <100.00%> (-0.84%) ⬇️
src/include/storage/store/node_column.h 100.00% <ø> (ø)
src/include/storage/store/node_group.h 100.00% <ø> (ø)
src/include/storage/store/string_column_chunk.h 100.00% <ø> (ø)
src/include/storage/store/var_list_column_chunk.h 87.50% <ø> (ø)
src/processor/map/map_copy_from.cpp 100.00% <100.00%> (+1.13%) ⬆️
src/processor/operator/persistent/copy_node.cpp 95.91% <100.00%> (ø)
src/storage/local_table.cpp 94.19% <100.00%> (ø)
src/storage/store/node_column.cpp 79.12% <100.00%> (-0.08%) ⬇️
... and 7 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit b5a73a8 into master Oct 11, 2023
10 of 11 checks passed
@ray6080 ray6080 deleted the column-chunk branch October 11, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants