Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setValueFromString from ColumnChunk #2169

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Oct 8, 2023

Casting now is done inside reader. This interface should no longer be used.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4aa1d07) 89.65% compared to head (9d2e725) 89.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
+ Coverage   89.65%   89.92%   +0.26%     
==========================================
  Files         989      989              
  Lines       35740    35624     -116     
==========================================
- Hits        32042    32034       -8     
+ Misses       3698     3590     -108     
Files Coverage Δ
src/include/storage/store/column_chunk.h 96.07% <ø> (+5.33%) ⬆️
src/include/storage/store/string_column_chunk.h 100.00% <100.00%> (ø)
src/include/storage/store/var_list_column_chunk.h 87.50% <ø> (ø)
src/storage/store/column_chunk.cpp 81.09% <ø> (+1.63%) ⬆️
src/storage/store/struct_column_chunk.cpp 82.14% <ø> (+59.59%) ⬆️
src/storage/store/var_list_column_chunk.cpp 86.53% <ø> (+6.18%) ⬆️
src/storage/store/string_column_chunk.cpp 67.56% <0.00%> (+6.59%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 531e50c into master Oct 9, 2023
10 of 11 checks passed
@ray6080 ray6080 deleted the clean-column-chunk branch October 9, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants