Clean up node_column.h and column_chunk.h #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
approved these changes
Oct 7, 2023
Some of the classes can be moved into the source files as they are only used by the factories. BoolNodeColumn was no longer needed and was removed
ray6080
force-pushed
the
storage-header-cleanup
branch
from
98e8a43
to
a030ef0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2164 +/- ##
==========================================
- Coverage 89.95% 89.91% -0.04%
==========================================
Files 989 989
Lines 35645 35637 -8
==========================================
- Hits 32065 32044 -21
- Misses 3580 3593 +13
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the classes can be moved into the source files as they are only used by the factories. BoolNodeColumn was no longer needed and was removed.
NullColumnChunk is referenced elsewhere, but otherwise the specific variants of ColumnChunk and NodeColumn are all now defined within the source files.
That said, node_column.cpp and column_chunk.cpp are now getting a little large.