-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidy: add clang-tidy #2156
tidy: add clang-tidy #2156
Conversation
d23354f
to
fb4860c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2156 +/- ##
==========================================
+ Coverage 89.92% 90.04% +0.11%
==========================================
Files 989 989
Lines 35637 35449 -188
==========================================
- Hits 32048 31919 -129
+ Misses 3589 3530 -59
☔ View full report in Codecov by Sentry. |
Is there a summarized list of checks we plan to integrate later? |
Not really, I plan to integrate everything except stuff I think is dumb or for which the check is poor quality. For instance, I disabled bugprone-exception-escape because of the poor quality of the errors. I disabled bugprone namespace forward declarations because I dont see how this could be an issue, and we had some warnings from it and Arrow. I disabled the widening multiplication becausr there are a lot of errors, and we need to fix that in its own PR. |
Remaining todo: add tests for the bugs I fixed. |
d45a96f
to
acf3a19
Compare
Note: we can't easily test returning |
clang-tidy is a static analyzer, and can find many different issues. So far I have integrated a few simple checks, and disabled the remaining ones. They will be enabled in future PRs.
Closes #2152. Ref #2148.