Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change print to sys.stdout.write and flush in benchmark_runner.py #2155

Merged
merged 2 commits into from
Oct 6, 2023
Merged

change print to sys.stdout.write and flush in benchmark_runner.py #2155

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5665c3
change print to sys.stdout.write and flush in benchmark_runner.py
Oct 5, 2023
6e90ce5
use print with flush arg instead of sys.stdout.write and flush
Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion benchmark/benchmark_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,8 @@ def run_kuzu(serialized_graph_path):
process = subprocess.Popen(
tuple(benchmark_cmd), stdout=subprocess.PIPE)
for line in iter(process.stdout.readline, b''):
print(line.decode("utf-8"), end='')
sys.stdout.write(line.decode("utf-8"))
sys.stdout.flush()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also use the flush argument of print to explicitly flush, which is a little more concise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

process.wait()
if process.returncode != 0:
print()
Expand Down