Link C and C++ API tests against the API-restricted shared library #2153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at this, mostly to see if it passes CI.
Implements part of #2136.
Various functions needed the
KUZU_API
annotation. Some of these are fine, such as~PreparedStatement
andStorageDriver
, which should be public.However a number of things which should really be private (e.g.
ValueVector::resetAuxiliaryBuffer
) had to be added to the exports since they are used in template functions related to the UDF helpers. While the templates themselves can't be moved into source files, we could probably hide some of their implementations, but I'm not sure if that really does anything other than expose something different which really should be private.I'm also not convinced that
ValueVector
was really written with external use in mind, as it has various public functions which users probably shouldn't be calling. However it is required forConnection::createVectorizedFunction
to work. I've only addedKUZU_API
to the bare minimum functions, but note that all inline functions (includinggetData()
for direct access to the buffer) would be usable.TODO:
Done; I threw them intoInMemOverflowBuffer::allocateSpace
could be removed from the exports if the variousoperation
functions are moved into cpp files.vector_string_functions.cpp
, though I'm not sure if that's ideal. They could have their own files, but the structure ofsrc/function
doesn't matchsrc/include/function
and I wasn't sure where they should go.