-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cast string to list #2145
cast string to list #2145
Conversation
|
1b79cf9
to
6805190
Compare
6054503
to
5b6d149
Compare
f6bd506
to
334209e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2145 +/- ##
==========================================
+ Coverage 90.06% 90.07% +0.01%
==========================================
Files 989 990 +1
Lines 35449 35515 +66
==========================================
+ Hits 31928 31991 +63
- Misses 3521 3524 +3
☔ View full report in Codecov by Sentry. |
@@ -19,6 +19,157 @@ namespace processor { | |||
|
|||
ParsingDriver::ParsingDriver(common::DataChunk& chunk) : chunk(chunk), rowEmpty(false) {} | |||
|
|||
void copyStringToVector(ValueVector* vector, uint64_t rowToAdd, std::string_view strVal, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you can remove this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cast to struct is still using this function
Change:
Next PR: