Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast string to list #2145

Merged
merged 1 commit into from
Oct 10, 2023
Merged

cast string to list #2145

merged 1 commit into from
Oct 10, 2023

Conversation

AEsir777
Copy link
Contributor

@AEsir777 AEsir777 commented Oct 4, 2023

Change:

  • driver newly upadated cast to string
  • change old castToUINT32 to new method
  • split header and cpp

Next PR:

  • fix NULL value displayed as ,,
  • currently spetial character can only be escaped as contained in quote " "
  • space

@AEsir777
Copy link
Contributor Author

AEsir777 commented Oct 5, 2023

Dataset New Old
20k INT64[] 337.95 2058.97
100k INT64[] 2322.9 9847.36200
10k INT64[][] 741.39 FAIL(when there is whitespace)
11k INT64[][] 782.11 4265.68

@AEsir777 AEsir777 changed the title cast string to list draft PR cast string to list Oct 6, 2023
dataset/load-from-test/bracket_fail.csv Outdated Show resolved Hide resolved
dataset/load-from-test/bracket_fail.csv Outdated Show resolved Hide resolved
src/function/cast_utils.cpp Outdated Show resolved Hide resolved
src/include/function/cast/cast_utils.h Outdated Show resolved Hide resolved
src/processor/operator/persistent/reader/csv/driver.cpp Outdated Show resolved Hide resolved
test/c_api/value_test.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3aae729) 90.06% compared to head (783bffd) 90.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2145      +/-   ##
==========================================
+ Coverage   90.06%   90.07%   +0.01%     
==========================================
  Files         989      990       +1     
  Lines       35449    35515      +66     
==========================================
+ Hits        31928    31991      +63     
- Misses       3521     3524       +3     
Files Coverage Δ
src/binder/bind/bind_graph_pattern.cpp 94.72% <100.00%> (ø)
src/common/type_utils.cpp 65.51% <ø> (-0.64%) ⬇️
src/include/common/type_utils.h 100.00% <ø> (ø)
src/include/function/cast/cast_functions.h 97.29% <ø> (ø)
src/include/function/cast/cast_utils.h 94.64% <ø> (ø)
src/include/function/cast/vector_cast_functions.h 95.65% <ø> (ø)
...age/in_mem_storage_structure/in_mem_column_chunk.h 72.72% <ø> (ø)
src/include/storage/store/column_chunk.h 95.12% <ø> (ø)
src/parser/transform/transform_expression.cpp 97.37% <ø> (ø)
...operator/persistent/reader/csv/base_csv_reader.cpp 100.00% <ø> (ø)
... and 3 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -19,6 +19,157 @@ namespace processor {

ParsingDriver::ParsingDriver(common::DataChunk& chunk) : chunk(chunk), rowEmpty(false) {}

void copyStringToVector(ValueVector* vector, uint64_t rowToAdd, std::string_view strVal,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can remove this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cast to struct is still using this function

src/processor/operator/persistent/reader/csv/driver.cpp Outdated Show resolved Hide resolved
@AEsir777 AEsir777 merged commit 0a0e7d7 into master Oct 10, 2023
11 checks passed
@AEsir777 AEsir777 deleted the cast branch October 10, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants