refactor: splitup table_functions.h #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2142 +/- ##
==========================================
- Coverage 89.63% 89.63% -0.01%
==========================================
Files 988 997 +9
Lines 35729 35729
==========================================
- Hits 32027 32024 -3
- Misses 3702 3705 +3
☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Oct 4, 2023
andyfengHKU
reviewed
Oct 4, 2023
Riolku
force-pushed
the
splitup-table-functions
branch
from
0f6f2be
to
cc1a65c
Compare
Riolku
added a commit
that referenced
this pull request
Oct 4, 2023
As mentioned by @benjaminwinger, since these functions are only reference in this source file, they need not be in headers, and can all be completely inlined in the source file instead. Ref #2142.
Riolku
added a commit
that referenced
this pull request
Oct 4, 2023
As mentioned by @benjaminwinger, since these functions are only reference in this source file, they need not be in headers, and can all be completely inlined in the source file instead. Ref #2142.
Riolku
added a commit
that referenced
this pull request
Oct 4, 2023
As mentioned by @benjaminwinger, since these functions are only reference in this source file, they need not be in headers, and can all be completely inlined in the source file instead. Ref #2142.
Riolku
added a commit
that referenced
this pull request
Oct 5, 2023
As mentioned by @benjaminwinger, since these functions are only reference in this source file, they need not be in headers, and can all be completely inlined in the source file instead. Ref #2142.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.